Upgrade cardano-base dependency #4699
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
requested changes
Oct 17, 2024
There was a problem hiding this comment.
@tdammers Please get rid of any changes related to serialization.
I wish you would have asked me before you went on wasting a lot of time on introducing all those changes.
We need to get rid of all KES related serialization form ledger, since ledger codebase does not depend on KES at all. So, please revert all of the additions with respect to KES and get rid of any serialization functionality for KES that was provided before
libs/cardano-ledger-binary/test/Test/Cardano/Ledger/Binary/RoundTripSpec.hs
Outdated
Show resolved
Hide resolved
lehins
force-pushed
the
tdammers/for-mlocked-kes-consensus
branch
5 times, most recently
from
cd58e1d
to
e2f0944
Compare
lehins
force-pushed
the
tdammers/for-mlocked-kes-consensus
branch
2 times, most recently
from
890a734
to
f1c33e4
Compare
lehins
force-pushed
the
tdammers/for-mlocked-kes-consensus
branch
2 times, most recently
from
15f7ecd
to
c33d9da
Compare
neilmayhew
force-pushed
the
tdammers/for-mlocked-kes-consensus
branch
from
c33d9da
to
41a6cef
Compare
neilmayhew
force-pushed
the
tdammers/for-mlocked-kes-consensus
branch
from
41a6cef
to
12d29c9
Compare
|
This now passes hydra CI but fails to build locally with |
lehins
force-pushed
the
tdammers/for-mlocked-kes-consensus
branch
from
12d29c9
to
d0828b1
Compare
lehins
force-pushed
the
tdammers/for-mlocked-kes-consensus
branch
from
d0828b1
to
1048b45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade dependency on
cardano-basein order to be compatible with upcoming versions ofouroboros-consensus.In current versions of
cardano-base, KES sign keys are stored in mlocked memory, and all operations involving them must now happen inIOorST. In order to facilitate existing pure code that isn't security-critical (e.g., generating mock data for testing purposes), the previous pure KES API is now provided asUnsoundPureKES, which we use here.Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)